OCPBUGS-38599: incorrect folder gen, workaround govmomi vm folder path bug #8861
Conversation
This PR resolves an issue when `folder` is undefined and datacenter exists as a child of a datacenter folder. instead of using DatacenterFolders.VmFolder we replace that with a path.Join of the datacenter InventoryPath, vm and the clusterID. This will provide the entire correct path to the hidden `/vm/` folder in vCenter.
jcpowermac
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jcpowermac: This pull request references Jira Issue OCPBUGS-38599, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/cherrypick release-4.17 release-4.16 |
|
@jcpowermac: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
cc: @WenXinWei |
|
govmomi bug |
|
/lgtm |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jcpowermac: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@jcpowermac: Jira Issue OCPBUGS-38599: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-38599 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jcpowermac: new pull request created: #8867 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
This PR resolves an issue when
folderis undefined and datacenter exists as a child of a datacenter folder. instead of using DatacenterFolders.VmFolder wereplace that with a path.Join of the datacenter InventoryPath, vm and the clusterID. This will provide the entire correct path to the hidden
/vm/folder in vCenter.